WIP: Allow inline/implicit matches to bind type symbols #5630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 756cd0a.
Allow abstracting over what context is needed by ConstraintHandling.
Merged
|
Closing in favour of #5657. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses constraint infrastructure from #5611.
Following code now passes typechecking:
c469970#diff-d8e17415f7fef27f0f81cd979db83c4a
Due to how we change
.info, inline matching on??? : tiftis pattern-bound does not typecheckc469970#diff-984c5e6efcdc62c8bbbb64967e67de90
The underlying issue is that some results are cached for the symbol before its info was changed.
In general, no code passes pickler roundtrips, including the following:
c469970#diff-7707ba03ed68a7c38cd6f5e3e3cd1ba7
The underlying issue seems to be re-using pattern-bound symbols as definitions.